search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
221 stars 39 forks source link

typo in makedocs #343

Closed ArnoStrouwen closed 6 months ago

ArnoStrouwen commented 7 months ago

https://github.com/SciML/NonlinearSolve.jl/issues/221 should likely not have been closed. It likely throws no errors about missing docs because of the typo.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e722fad) 88.02% compared to head (89692c5) 85.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #343 +/- ## ========================================== - Coverage 88.02% 85.81% -2.22% ========================================== Files 28 28 Lines 2172 2171 -1 ========================================== - Hits 1912 1863 -49 - Misses 260 308 +48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 7 months ago

Oops yeah. One thing, though, none of the "not included" ones should be included. Is there a way to pass ignore these.. to makedocs?

ArnoStrouwen commented 7 months ago

I don't think so. See, https://github.com/JuliaDocs/Documenter.jl/issues/2383.

avik-pal commented 6 months ago

re-enabled the warnonly argument. Let's wait for https://github.com/JuliaDocs/Documenter.jl/issues/2383 before we can disable it