search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
232 stars 40 forks source link

Handle polyalgorithm aliasing correctly #392

Closed avik-pal closed 6 months ago

avik-pal commented 6 months ago

Aliasing is messy :sweat:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 73.84615% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 86.73%. Comparing base (e1c0528) to head (45e0716).

Files Patch % Lines
src/default.jl 72.88% 16 Missing :warning:
src/utils.jl 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #392 +/- ## ========================================== - Coverage 86.92% 86.73% -0.19% ========================================== Files 46 46 Lines 2760 2797 +37 ========================================== + Hits 2399 2426 +27 - Misses 361 371 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 6 months ago

Yes, I want a whole aliasing system in general, but this'll do for now.