search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
216 stars 39 forks source link

Add a wrapper for Optimization.jl #395

Open avik-pal opened 3 months ago

avik-pal commented 3 months ago

Unfortunately, this introduces a massive circular dependency if Optimization is loaded. But we only pay the price in CI rn.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.63%. Comparing base (b7ba71d) to head (3617d6f).

Files Patch % Lines
ext/NonlinearSolveOptimizationExt.jl 95.23% 2 Missing :warning:
src/algorithms/extension_algs.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #395 +/- ## ========================================== - Coverage 81.16% 80.63% -0.54% ========================================== Files 46 47 +1 Lines 2804 2850 +46 ========================================== + Hits 2276 2298 +22 - Misses 528 552 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 3 months ago

Why not just add this code to OptmizationBase and document it here?

avik-pal commented 3 months ago

That's probably a better way I will do that