Closed avik-pal closed 2 months ago
With this PR all of the following work:
using NonlinearSolve, LinearSolve
function nlls!(du, u, p)
du[1] = 2u[1] - 2
du[2] = (u[1] - 4u[2])^2 + 0.1
du[3] = 0
end
u0 = [0.0, 0.0]
prob = NonlinearLeastSquaresProblem(
NonlinearFunction(nlls!, resid_prototype = zeros(3)), u0)
solve(prob)
solve(prob, GaussNewton(; linsolve = QRFactorization()))
solve(prob, GaussNewton(; linsolve = LUFactorization()))
I always display a warning rn, but I will configure the verbose
to not show the warning if needed.
Attention: Patch coverage is 73.73737%
with 26 lines
in your changes are missing coverage. Please review.
Project coverage is 86.34%. Comparing base (
b389d0e
) to head (914f556
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Needs https://github.com/SciML/LinearSolve.jl/pull/494 before the tests pass
@ChrisRackauckas do you have a suggestion on how to deal with this
How do we deal with non-standard Arrays? Basically how do we determine that PivotedQR is defined for the matrix A
Apart for this, we are good to go here.
Okay maybe we can use ArrayInterface.isstructured
and AnyGPUArray
to safeguard against this
Current approach is:
TODOs
verbose
to turn off printing@ChrisRackauckas any idea how to handle this last part?