SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
216 stars 39 forks source link

Upgrade to ADTypes v1 #426

Closed gdalle closed 1 month ago

gdalle commented 1 month ago

Supersedes #412

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.70%. Comparing base (17bb8a8) to head (844d78c).

Files Patch % Lines
src/internal/jacobian.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #426 +/- ## ========================================== - Coverage 86.30% 85.70% -0.60% ========================================== Files 47 47 Lines 2913 2904 -9 ========================================== - Hits 2514 2489 -25 - Misses 399 415 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 1 month ago

I don't understand what the formatting check does? It doesn't seem related to JuliaFormatter

ChrisRackauckas commented 1 month ago

It is JuliaFormatter. It's saying you haven't ran the formatter on this.

gdalle commented 1 month ago

@avik-pal this is starting to look decent in my view

gdalle commented 1 month ago

Thanks for the merge! Can we tag a new release?

https://github.com/SciML/NonlinearSolve.jl/pull/429