search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
216 stars 39 forks source link

CompatHelper: bump compat for FastBroadcast to 0.3, (keep existing compat) #434

Closed github-actions[bot] closed 1 month ago

github-actions[bot] commented 1 month ago

This pull request changes the compat entry for the FastBroadcast package from 0.2.8 to 0.2.8, 0.3. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.49%. Comparing base (86bb307) to head (00b4423). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #434 +/- ## =========================================== - Coverage 86.46% 54.49% -31.97% =========================================== Files 47 47 Lines 2904 2901 -3 =========================================== - Hits 2511 1581 -930 - Misses 393 1320 +927 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chriselrod commented 1 month ago

@avik-pal I've not looked at all the failures, but the ones I did look at were due to incompatible versions. I.e., other packages also depend on FastBroadcast.jl, but haven't had their patch versions bumped.

I think we should release a package that passes tests, and not care about failures due to version incompatibilities. E.g., someone installing OrdinaryDiffEq will safely get an older FastBroadcast, and thus won't experience breakages. When it comes to the downstream packages tests, if they do encounter failures, we can fix them in e.g. FastBroadcast 0.3.1, and then add that as the compat there.

If you saw real test failures among these, please let me know.

avik-pal commented 1 month ago

@chriselrod just to confirm, there are no API changes in FastBroadcast, right? From the commits it seems to be mostly an internal implementation detail that changed

chriselrod commented 1 month ago

@chriselrod just to confirm, there are no API changes in FastBroadcast, right? From the commits it seems to be mostly an internal implementation detail that changed

No API change. It was a major internal change, so there is a risk of accidental/unintended breakage. That is the reason I cautiously made the release breaking.