SciML / ODE.jl

Assorted basic Ordinary Differential Equation solvers for scientific machine learning (SciML). Deprecated: Use DifferentialEquations.jl instead.
Other
105 stars 49 forks source link

Added DOPRI78 tableau from DifferentialEquations.jl #101

Closed mauro3 closed 6 years ago

mauro3 commented 8 years ago

Note that I had to increase the test tolerance tol for the new solver to pass. This is not due to an in-accurate solver but due to the dense output only being 3rd order. This made this test fail: https://github.com/JuliaLang/ODE.jl/blob/a0ef97d6249e62a089370787850ae697e3d94962/test/runtests.jl#L60

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 93.691% when pulling 9345a71deca5d6f0ae78faabca2771d177d68a53 on mauro3:m3/dopri78 into a0ef97d6249e62a089370787850ae697e3d94962 on JuliaLang:master.

codecov-io commented 8 years ago

Current coverage is 93.69%

Merging #101 into master will increase coverage by 0.04%

@@             master       #101   diff @@
==========================================
  Files             2          2          
  Lines           315        317     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            295        297     +2   
  Misses           20         20          
  Partials          0          0          

Powered by Codecov. Last updated by a0ef97d...9345a71

ChrisRackauckas commented 8 years ago

The order of the dense output would render the test mostly moot. It's probably best to test at a calculated point (like the endpoint) since that would have a much higher accuracy for most of the methods. Then the tolerance could be far reduced (or dependent on the method order)

mauro3 commented 8 years ago

Yes, the tests need some love but that should be coming with #49. I think it would be fine to mere this now, or close. However, the tableau is not copied to #49 yet.

ChrisRackauckas commented 8 years ago

Alright. I'll take that as a separate issue then, but the tests will need to be overhauled (I think some kind of more precise integration test than what's going on here would help). Is that handled in #49? If not, an issue should be opened discussing some ideas on how to improve the tests.

But this can't merge until the conflicts are resolved. I'm kinda surprised that this would conflict with something. Is it just the BS2/3 line spacing change that conflicts with the just merged #97?

mauro3 commented 8 years ago

Ok, I'll update this. I'll see whether I got time today, afterwards I'm away from the computer for a 5 days.

pwl commented 8 years ago

@ChrisRackauckas I encourage you to post an issue for #49, the new tests are pretty fresh and we any comments/improvements on them are welcome. Also, dense output and integrators are now completely separated in #49, which means you can test an integrator without invoking dense output.