SciML / ODE.jl

Assorted basic Ordinary Differential Equation solvers for scientific machine learning (SciML). Deprecated: Use DifferentialEquations.jl instead.

Other

105 stars 49 forks source link

Fix #166, add checks for keyword arguments to make sure valid for thi… #132

Closed ScottPJones closed 7 years ago

ScottPJones commented 7 years ago

…s solver

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling b8a646ea1cc1d106a11f3ecfa62f7dffe7b5f6dc on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling b8a646ea1cc1d106a11f3ecfa62f7dffe7b5f6dc on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling b8a646ea1cc1d106a11f3ecfa62f7dffe7b5f6dc on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling b8a646ea1cc1d106a11f3ecfa62f7dffe7b5f6dc on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling 7790833c560a0cfdb4a3c719d0f0c8df30c079bf on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling 7790833c560a0cfdb4a3c719d0f0c8df30c079bf on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling 7790833c560a0cfdb4a3c719d0f0c8df30c079bf on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling 7790833c560a0cfdb4a3c719d0f0c8df30c079bf on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 91.304% when pulling 7790833c560a0cfdb4a3c719d0f0c8df30c079bf on ScottPJones:spj/fix166 into ff1b4581622103c86808420bd236c90099ace8ec on JuliaDiffEq:master.

ScottPJones commented 7 years ago

I think we need to look at how the coverage is dealt with, because we probably only want to do it once, maybe on latest.

codecov-io commented 7 years ago

Codecov Report

Merging #132 into master will increase coverage by 0.04%. The diff coverage is 50%.

@@            Coverage Diff            @@
##           master    #132      +/-   ##
=========================================
+ Coverage   91.25%   91.3%   +0.04%     
=========================================
  Files           4       4              
  Lines         366     368       +2     
=========================================
+ Hits          334     336       +2     
  Misses         32      32

Impacted Files	Coverage Δ
src/ODE.jl	`93.91% <100%> (+0.04%)`	:arrow_up:
src/common.jl	`71.79% <45.45%> (+0.74%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff1b458...7790833. Read the comment docs.