search

SciML / OperatorLearning.jl

No need to train, he's a smooth operator
https://operatorlearning.sciml.ai/dev
MIT License
43 stars 8 forks source link

Test on current stable release instead of nightly #30

Closed ChrisRackauckas closed 2 years ago

ChrisRackauckas commented 2 years ago

Nightly is not generally going to work with autodiff, while this was not testing on current stable release (v1.7) which is what most users are likely on. We usually prefer to test on stable + LTS.

ChrisRackauckas commented 2 years ago

Also made it so it doesn't double test all versions.

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (65c7a48) into master (90516c4) will increase coverage by 0.83%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   40.25%   41.09%   +0.83%     
==========================================
  Files           6        6              
  Lines          77       73       -4     
==========================================
- Hits           31       30       -1     
+ Misses         46       43       -3
Impacted Files Coverage Δ
src/batched.jl 0.00% <0.00%> (ø)
src/subnets.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90516c4...65c7a48. Read the comment docs.

ChrisRackauckas commented 2 years ago

@pzimbrod I removed the unused dependencies like Revise, MAT, etc. which I assume were used in testing but aren't used in the repo.

pzimbrod commented 2 years ago

@pzimbrod I removed the unused dependencies like Revise, MAT, etc. which I assume were used in testing but aren't used in the repo.

Yup, used them for testing but no need for them in the package