search

SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.
https://docs.sciml.ai/Optimization/stable/
MIT License
711 stars 79 forks source link

Some NLopt and MOI updates #562

Closed Vaibhavdixit02 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #562 (7565cf2) into master (8682f9c) will increase coverage by 0.00%. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   10.46%   10.47%           
=======================================
  Files          40       40           
  Lines        2322     2320    -2     
=======================================
  Hits          243      243           
+ Misses       2079     2077    -2
Impacted Files Coverage Δ
lib/OptimizationMOI/src/nlp.jl 0.00% <0.00%> (ø)
lib/OptimizationNLopt/src/OptimizationNLopt.jl 0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Vaibhavdixit02 commented 1 year ago

This isn't sufficient, the C wrappers of other optimizers are hardcoded to give out Float64s so we can't make this handling completely automatic. The loss function would need to do a Float32 conversion despite this. But this is probably good to have even otherwise so merging this.