SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.
https://docs.sciml.ai/Optimization/stable/
MIT License
711 stars 79 forks source link

remove second copy of __moi_status_to_ReturnCode #568

Closed visr closed 1 year ago

visr commented 1 year ago

These two functions are indentical: https://github.com/SciML/Optimization.jl/blob/f911aba86b981d03941223bc284c04fff3b05ec0/lib/OptimizationMOI/src/OptimizationMOI.jl#L75 https://github.com/SciML/Optimization.jl/blob/f911aba86b981d03941223bc284c04fff3b05ec0/lib/OptimizationMOI/src/OptimizationMOI.jl#L164

Fixes precompilation of OptimizationMOI:

  1 dependency had warnings during precompilation:
┌ OptimizationMOI [fd9f6733-72f4-499f-8506-86b2bdd0dea1]
│  WARNING: Method definition __moi_status_to_ReturnCode(MathOptInterface.TerminationStatusCode) in module OptimizationMOI at .julia\packages\OptimizationMOI\QjPKM\src\OptimizationMOI.jl:75 overwritten at .julia\packages\OptimizationMOI\QjPKM\src\OptimizationMOI.jl:164.
│    ** incremental compilation may be fatally broken for this module **
└
Vaibhavdixit02 commented 1 year ago

Probably a bad rebase! Thanks for the catch, will merge once tests pass

codecov[bot] commented 1 year ago

Codecov Report

Merging #568 (6ba23de) into master (f911aba) will decrease coverage by 1.03%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #568      +/-   ##
=========================================
- Coverage   10.27%   9.24%   -1.03%     
=========================================
  Files          41      41              
  Lines        2374    2346      -28     
=========================================
- Hits          244     217      -27     
+ Misses       2130    2129       -1     
Impacted Files Coverage Δ
lib/OptimizationMOI/src/OptimizationMOI.jl 0.00% <ø> (-1.15%) :arrow_down:

... and 9 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more