SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.
https://docs.sciml.ai/Optimization/stable/
MIT License
711 stars 79 forks source link

Fix typos in the extension names #582

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

Someone's going to have to handle the filenames manually though I think because just a caps difference isn't showing up in my Git as a change to commit.

codecov[bot] commented 1 year ago

Codecov Report

Merging #582 (3f5022b) into master (2233bbc) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   10.19%   10.19%           
=======================================
  Files          41       41           
  Lines        2451     2451           
=======================================
  Hits          250      250           
  Misses       2201     2201           
Files Changed Coverage Δ
ext/OptimizationFiniteDiffExt.jl 0.00% <ø> (ø)
ext/OptimizationForwardDiffExt.jl 0.00% <ø> (ø)
ext/OptimizationReverseDiffExt.jl 0.00% <ø> (ø)
ext/OptimizationSparseFiniteDiffExt.jl 0.00% <ø> (ø)
ext/OptimizationSparseForwardDiffExt.jl 0.00% <ø> (ø)
src/Optimization.jl 33.33% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Vaibhavdixit02 commented 1 year ago

The casing is better this way, but I don't think I understand why this would make a difference to the precompilation warning?

ChrisRackauckas commented 1 year ago

I thought you had a typo somewhere causing it because these were all incorrect, so one that was correct would lead to an issue. This didn't solve the issue, but it at least rules out an issue.

Vaibhavdixit02 commented 1 year ago

Yeah makes sense. I think the imports are the issue as you pointed out in the issue

ChrisRackauckas commented 1 year ago

In an extension you're only supposed to import the package or its extensions, not other dependencies. You can grab the dependencies via Optimization.Symbolics but are not supposed to actually import from the global space