Closed ChrisRackauckas closed 1 year ago
Merging #582 (3f5022b) into master (2233bbc) will not change coverage. The diff coverage is
0.00%
.
@@ Coverage Diff @@
## master #582 +/- ##
=======================================
Coverage 10.19% 10.19%
=======================================
Files 41 41
Lines 2451 2451
=======================================
Hits 250 250
Misses 2201 2201
Files Changed | Coverage Δ | |
---|---|---|
ext/OptimizationFiniteDiffExt.jl | 0.00% <ø> (ø) |
|
ext/OptimizationForwardDiffExt.jl | 0.00% <ø> (ø) |
|
ext/OptimizationReverseDiffExt.jl | 0.00% <ø> (ø) |
|
ext/OptimizationSparseFiniteDiffExt.jl | 0.00% <ø> (ø) |
|
ext/OptimizationSparseForwardDiffExt.jl | 0.00% <ø> (ø) |
|
src/Optimization.jl | 33.33% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
The casing is better this way, but I don't think I understand why this would make a difference to the precompilation warning?
I thought you had a typo somewhere causing it because these were all incorrect, so one that was correct would lead to an issue. This didn't solve the issue, but it at least rules out an issue.
Yeah makes sense. I think the imports are the issue as you pointed out in the issue
In an extension you're only supposed to import the package or its extensions, not other dependencies. You can grab the dependencies via Optimization.Symbolics
but are not supposed to actually import from the global space
Someone's going to have to handle the filenames manually though I think because just a caps difference isn't showing up in my Git as a change to commit.