SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.
https://docs.sciml.ai/Optimization/stable/
MIT License
691 stars 75 forks source link

[WIP]Stats and State #652

Closed Vaibhavdixit02 closed 6 months ago

Vaibhavdixit02 commented 6 months ago

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (80d8465) 8.46% compared to head (c0e59f6) 8.70%.

:exclamation: Current head c0e59f6 differs from pull request most recent head abfa548. Consider uploading reports for the commit abfa548 to get more accurate results

Files Patch % Lines
lib/OptimizationFlux/src/OptimizationFlux.jl 0.00% 7 Missing :warning:
...onStrategy/src/OptimizationCMAEvolutionStrategy.jl 0.00% 6 Missing :warning:
lib/OptimizationBBO/src/OptimizationBBO.jl 0.00% 5 Missing :warning:
...zationEvolutionary/src/OptimizationEvolutionary.jl 0.00% 4 Missing :warning:
lib/OptimizationMOI/src/nlp.jl 0.00% 4 Missing :warning:
lib/OptimizationOptimJL/src/OptimizationOptimJL.jl 63.63% 4 Missing :warning:
lib/OptimizationNLopt/src/OptimizationNLopt.jl 0.00% 3 Missing :warning:
lib/OptimizationGCMAES/src/OptimizationGCMAES.jl 0.00% 2 Missing :warning:
...mization/src/OptimizationMultistartOptimization.jl 0.00% 2 Missing :warning:
lib/OptimizationMOI/src/moi.jl 0.00% 1 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #652 +/- ## ========================================= + Coverage 8.46% 8.70% +0.24% ========================================= Files 30 31 +1 Lines 2470 2504 +34 ========================================= + Hits 209 218 +9 - Misses 2261 2286 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 6 months ago

Maybe it's time for a new design of the arguments list?

sethaxen commented 6 months ago

@Vaibhavdixit02 The changes to most of the integration packages are marked as breaking, but there's no description for me to know whether it is safe to upgrade. Would it be possible to summarize what this PR does and in what way it is breaking?

Vaibhavdixit02 commented 6 months ago

@sethaxen sure, it was breaking because the callback arguments have changed, instead of the optimization variables as the first argument now it will be a OptimizationState object. I have updated most of the docstring and am working on getting the examples updated, I am trying to get it done by this weekend!

sethaxen commented 6 months ago

Thanks, @Vaibhavdixit02 !

ChrisRackauckas commented 6 months ago

We need to add a note on the README

oscardssmith commented 5 months ago

Since this was a breaking change, shouldn't this have required a major version bump?

ChrisRackauckas commented 5 months ago

It did get a major IIRC

SebastianM-C commented 5 months ago

Optimization.jl didn't get a major version bump, but the backends did get a minor bump (since they are 0.x).