Closed Vaibhavdixit02 closed 6 months ago
Attention: 44 lines
in your changes are missing coverage. Please review.
Comparison is base (
80d8465
) 8.46% compared to head (c0e59f6
) 8.70%.:exclamation: Current head c0e59f6 differs from pull request most recent head abfa548. Consider uploading reports for the commit abfa548 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Maybe it's time for a new design of the arguments list?
@Vaibhavdixit02 The changes to most of the integration packages are marked as breaking, but there's no description for me to know whether it is safe to upgrade. Would it be possible to summarize what this PR does and in what way it is breaking?
@sethaxen sure, it was breaking because the callback arguments have changed, instead of the optimization variables as the first argument now it will be a OptimizationState
object. I have updated most of the docstring and am working on getting the examples updated, I am trying to get it done by this weekend!
Thanks, @Vaibhavdixit02 !
We need to add a note on the README
Since this was a breaking change, shouldn't this have required a major version bump?
It did get a major IIRC
Optimization.jl didn't get a major version bump, but the backends did get a minor bump (since they are 0.x).
Checklist
Additional context
Add any other context about the problem here.