refactor: update for MTKv9

SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.

https://docs.sciml.ai/Optimization/stable/

MIT License

691 stars 75 forks source link

refactor: update for MTKv9 #685

Closed AayushSabharwal closed 4 months ago

AayushSabharwal commented 5 months ago

I'll separate this PR out into another one that contains changes independent of v9

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.84%. Comparing base (a65ef30) to head (d4f90fd). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #685 +/- ## =========================================== + Coverage 8.65% 40.84% +32.18% =========================================== Files 31 31 Lines 2506 2522 +16 =========================================== + Hits 217 1030 +813 + Misses 2289 1492 -797 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AayushSabharwal commented 5 months ago

The type-piracy removal is now in https://github.com/SciML/Optimization.jl/pull/689 so it can be merged independent of MTKv9

ChrisRackauckas commented 5 months ago

Does this still need to be a draft?

ChrisRackauckas commented 4 months ago

Test failure.

AayushSabharwal commented 4 months ago

MOI tests pass locally, I'm not sure why it doesn't resolve here. MTK probably doesn't pass because it isn't using the local OptimizationMOI

ChrisRackauckas commented 4 months ago

Passes now!

ChrisRackauckas commented 4 months ago

The docs failures look real.

AayushSabharwal commented 4 months ago

Docs are probably failing because It's using OptimizationMOI v0.1.16. Bumping MTK compat makes it use v0.1.9 which is weird.

AayushSabharwal commented 4 months ago

So I can fix compat, but CI doesn't checkout the subpackages (specifically OptimizationMOI) so they won't build here

AayushSabharwal commented 4 months ago

Also docs doesn't have compat for the latest version of

OptimizationPRIMA
OptimizationSpeedMapping And OptimizationQuadDIRECT requires a different registry entirely

I'm trying to build docs locally by bumping compat for the first two packages and deving all the packages except QuadDIRECT. If it builds, should I also update CI?