refactor: remove type-pirated functions

SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.

https://docs.sciml.ai/Optimization/stable/

MIT License

720 stars 79 forks source link

refactor: remove type-pirated functions #689

Closed AayushSabharwal closed 8 months ago

AayushSabharwal commented 8 months ago

moved to SciMLBase

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (28028fe) 8.62% compared to head (402b347) 8.53%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #689 +/- ## ========================================= - Coverage 8.62% 8.53% -0.10% ========================================= Files 31 31 Lines 2515 2496 -19 ========================================= - Hits 217 213 -4 + Misses 2298 2283 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 8 months ago

downgrade tests are failing: needs a bump?

Vaibhavdixit02 commented 8 months ago

Yeah it should be bounded to 2.23.0 with this PR. Ref #692