search

SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.
https://docs.sciml.ai/Optimization/stable/
MIT License
688 stars 75 forks source link

Update #711 checking if OptimizationFunction is used for derivative based optimizers #711 #715

Closed ParasPuneetSingh closed 3 months ago

ParasPuneetSingh commented 4 months ago

Added checking if OptimizationFunction is used for derivative based optimizers #711

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 11.37%. Comparing base (80f2155) to head (e0610cd). Report is 2 commits behind head on master.

Files Patch % Lines
lib/OptimizationNLopt/src/OptimizationNLopt.jl 0.00% 20 Missing :warning:
lib/OptimizationOptimJL/src/OptimizationOptimJL.jl 0.00% 7 Missing :warning:
...onStrategy/src/OptimizationCMAEvolutionStrategy.jl 0.00% 4 Missing :warning:
...zationEvolutionary/src/OptimizationEvolutionary.jl 0.00% 4 Missing :warning:
lib/OptimizationFlux/src/OptimizationFlux.jl 0.00% 4 Missing :warning:
lib/OptimizationGCMAES/src/OptimizationGCMAES.jl 0.00% 4 Missing :warning:
lib/OptimizationMOI/src/OptimizationMOI.jl 0.00% 4 Missing :warning:
...timizationOptimisers/src/OptimizationOptimisers.jl 0.00% 1 Missing :warning:
...onPolyalgorithms/src/OptimizationPolyalgorithms.jl 0.00% 1 Missing :warning:
...zationSpeedMapping/src/OptimizationSpeedMapping.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #715 +/- ## =========================================== - Coverage 66.01% 11.37% -54.64% =========================================== Files 22 22 Lines 1477 1512 +35 =========================================== - Hits 975 172 -803 - Misses 502 1340 +838 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Vaibhavdixit02 commented 3 months ago

@ParasPuneetSingh there's a few errors here please fix them from the CI run it seems like syntax issues

ParasPuneetSingh commented 3 months ago

I checked the Cl run and corrected the syntax errors in OptimizationNLopt.jl but now it says that "Optim.AbstractOptimizer" is not a valid function argument name, but it has been used for other traits as well, I don't get this syntax error.