SciML / Optimization.jl

Mathematical Optimization in Julia. Local, global, gradient-based and derivative-free. Linear, Quadratic, Convex, Mixed-Integer, and Nonlinear Optimization in one simple, fast, and differentiable interface.
https://docs.sciml.ai/Optimization/stable/
MIT License
688 stars 75 forks source link

fix duplicated methods #762

Closed daviehh closed 1 month ago

daviehh commented 1 month ago

Checklist

Additional context

The commit near https://github.com/SciML/Optimization.jl/commit/bdc46f0568cf49fb3abe3ea27e60b59081b3e8fc added some duplicate methods, causing precompile errors.

WARNING: Method definition requireshessian(NLopt.Algorithm) in module OptimizationNLopt at /Users/david/.julia/packages/OptimizationNLopt/zjxSh/src/OptimizationNLopt.jl:21 overwritten at /Users/david/.julia/packages/OptimizationNLopt/zjxSh/src/OptimizationNLopt.jl:30.
ERROR: Method overwriting is not permitted during Module precompilation. Use `__precompile__(false)` to opt-out of precompilation.

This PR removes the duplicates.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.06%. Comparing base (19da423) to head (f5ae5b0). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #762 +/- ## ========================================== - Coverage 67.46% 0.06% -67.40% ========================================== Files 22 22 Lines 1632 1580 -52 ========================================== - Hits 1101 1 -1100 - Misses 531 1579 +1048 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.