[WIP]Start experimenting with DI

SciML / OptimizationBase.jl

The base package for Optimization.jl, containing the structs and basic functions for it.

MIT License

14 stars 6 forks source link

[WIP]Start experimenting with DI #31

Closed Vaibhavdixit02 closed 4 months ago

Vaibhavdixit02 commented 6 months ago

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

gdalle commented 5 months ago

@Vaibhavdixit02 DifferentiationInterface v0.2 is out, and we got rid of the bang-bang in favor of always mutating the provided storage. This will make all of our lives easier

gdalle commented 5 months ago

@Vaibhavdixit02 DI v0.3 is out, and it even removes the need for SparseDiffTools in the simplest cases. Take it for a spin!

gdalle commented 4 months ago

You need a more recent version of DI, at least 0.5.1 for Enzyme to work in second order and 0.5.2 for it to be fast. The tests are still running with 0.5.0.

Vaibhavdixit02 commented 4 months ago

Come on, I run all tests against DI master locally depending on releases is for p**! 🤣

gdalle commented 4 months ago

It seems the last tests were run 3 days ago, you closing and reopening has apparently not re-triggered CI

Vaibhavdixit02 commented 4 months ago

Because of the merge conflict

gdalle commented 4 months ago

Indeed you pushed a merge conflict at least in the project file