Remove AutoMTK constructor overload here

SciML / OptimizationBase.jl

The base package for Optimization.jl, containing the structs and basic functions for it.

MIT License

8 stars 5 forks source link

Closed Vaibhavdixit02 closed 3 weeks ago

Vaibhavdixit02 commented 3 weeks ago

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Fixes #55

gdalle commented 3 weeks ago

AutoModelingToolkit is deprecated so I think the solution is to avoid relying on it altogether, not reintroduce it in ADTypes

ChrisRackauckas commented 3 weeks ago

Well we should make the deprecation path actually correct. The issue is that the deprecation is not correct.

ChrisRackauckas commented 3 weeks ago

Deprecation paths are all working here! Lots of work to be done, but that's a big win.