added ROS2 method and added ROS2, ROS23 and ROS34PW methods to iipvsoop_test.jl

SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)

https://diffeq.sciml.ai/latest/

Other

523 stars 199 forks source link

added ROS2 method and added ROS2, ROS23 and ROS34PW methods to iipvsoop_test.jl #2165

Closed cwittens closed 2 months ago

cwittens commented 3 months ago

Checklist

[x] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

closes https://github.com/SciML/OrdinaryDiffEq.jl/issues/2112

cwittens commented 3 months ago

Thanks a lot! This looks mostly good to me. Did you test it also with some additional ODEs?

What do you mean?

ranocha commented 3 months ago

Thanks a lot! This looks mostly good to me. Did you test it also with some additional ODEs?

What do you mean?

There are some tests in the test folder. Did you also run the new method for additional ODEs to check that they work as expected?

Anyway, nice work :+1:

ranocha commented 3 months ago

Some Rosenbrock tests fail - I guess that's related to this PR?

ChrisRackauckas commented 3 months ago

yes definitely introduced here

ranocha commented 2 months ago

Most failing CI runs are caused by Codecov (see https://github.com/codecov/feedback/issues/301). The only exception is https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/8753631634/job/24023730348?pr=2165#step:6:956

Could you please check whether this PR causes that or whether this happens also on the current master branch?

ChrisRackauckas commented 2 months ago

This PR doesn't cause that. I need to fix that one up.

But those Rosenbrock tests need to be added here.

ChrisRackauckas commented 2 months ago

Okay yeah this looks good.