SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)
https://diffeq.sciml.ai/latest/
Other
536 stars 205 forks source link

fix default solver interpolation #2245

Closed oscardssmith closed 3 months ago

oscardssmith commented 3 months ago

Fixes issue observed by @TorkelE where the default solver wasn't interpolating properly.

ChrisRackauckas commented 3 months ago

Merge when tests pass.

ChrisRackauckas commented 3 months ago

Oh this right here?

https://github.com/SciML/OrdinaryDiffEq.jl/pull/2245/files/c5e292415127e344d7084acd1cee86001e05bd36#diff-880197818e0d2bb2dab8f58cc3be7df428ac18e981932f5de86923a298405d66R496

Yeah that looks like a typo

oscardssmith commented 3 months ago

good catch. Not a problem, but unintended and easy to fix.https://github.com/SciML/OrdinaryDiffEq.jl/pull/2248