search

SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)
https://diffeq.sciml.ai/latest/
Other
536 stars 205 forks source link

Fix `QNDF` alg_events test #2249

Closed oscardssmith closed 3 months ago

oscardssmith commented 3 months ago

https://github.com/SciML/OrdinaryDiffEq.jl/pull/2233 merged slightly too early, but this fixes the failing test. The problem was that the test was comparing a QNDF solve to an FBDF solve where the solves had an abstol of 1e-8 but we were looking for agreement of 1e-8. Reducing the abstol of the solve to 1e-10 fixes the failure.