SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)
https://diffeq.sciml.ai/latest/
Other
521 stars 198 forks source link

Added Low Storage RK methods #2256

Closed ParamThakkar123 closed 1 week ago

ParamThakkar123 commented 1 week ago

Checklist

Additional context

Add any other context about the problem here.

Solves a part of #2177

ChrisRackauckas commented 1 week ago

Rebase onto the new master.

ParamThakkar123 commented 1 week ago

image

How should I resolve this ?? I made the import but can't figure out where I am mistaken

ParamThakkar123 commented 1 week ago

image

@ChrisRackauckas what about this ?? This doesn't have any mention in the docs as low storage rk in the code base it has a definition in explicit_rk and ssprk_caches.jl

ChrisRackauckas commented 1 week ago

SHLDDRK_2N is an SSPRK method so it should be included with that set, not this one. Just remove it from the alg_utils.jl here.

ChrisRackauckas commented 1 week ago

False comes from Static.jl, so that should be a dep

ParamThakkar123 commented 1 week ago

image

A IRKC undef error in controllers.jl. I defined IRKC on ordinaryDiffEq on line 245 in the way above. And in controllers.jl:

image

ParamThakkar123 commented 1 week ago

image

Here it shows IRKC is not defined but I have imported it in controllers.jl

ParamThakkar123 commented 1 week ago

@ChrisRackauckas @ranocha All the UnDef errors are now fixed. Now, There are some errors related to dimension mismatch, precision and method loading. How can I fix this ??

ParamThakkar123 commented 1 week ago

@ChrisRackauckas Any changes to make??

ParamThakkar123 commented 1 week ago

@ChrisRackauckas Should I start working on the other solvers as well ?? Simultaneously

ChrisRackauckas commented 1 week ago

yes just make sure to branch first. It looks like you're working on your fork's master here.

ParamThakkar123 commented 1 week ago

Yes. I was working in my fork's master. I will sync it with the upstream and also make do the branching

ParamThakkar123 commented 1 week ago

@ChrisRackauckas I started a new PR for SSPRK methods: #2264