Added SSPRK methods - Githubissues

SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)

https://diffeq.sciml.ai/latest/

Other

536 stars 205 forks source link

Added SSPRK methods #2264

Closed ParamThakkar123 closed 3 months ago

ParamThakkar123 commented 3 months ago

Checklist

[X] Appropriate tests were added
[X] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[X] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here. Solves a part of #2177

ParamThakkar123 commented 3 months ago

There are some version errors here related to the packages

ParamThakkar123 commented 3 months ago

I ran the runtests.jl inside OrdinaryDiffEqSSPRK and it worked.

ChrisRackauckas commented 3 months ago

It's related to https://github.com/YingboMa/FastBroadcast.jl/pull/64. Should be cleaned up in a little bit. Just branch for another set. Maybe do the Feagin next, those should be rather easy.

ParamThakkar123 commented 3 months ago

@ChrisRackauckas I started a new PR on #2267 for Feagin

ParamThakkar123 commented 3 months ago

But it also has the same version errors

ChrisRackauckas commented 3 months ago

rebase to latest master

ParamThakkar123 commented 3 months ago

@ChrisRackauckas Should I close both these PRs and start over again. Because I think there might be some problem on my end.

ChrisRackauckas commented 3 months ago

no just. rebase to get the compat fix

ParamThakkar123 commented 3 months ago

@ChrisRackauckas

This error occurred in integrator_interface.jl. It could not import SSPRK22 from OrdinaryDiffEq.jl. How can I fix this ??

ChrisRackauckas commented 3 months ago

You just need to move these functions to the lib.

https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/integrators/integrator_interface.jl#L118-L121