Added Rosenbrock methods

SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)

https://diffeq.sciml.ai/latest/

Other

536 stars 205 forks source link

Added Rosenbrock methods #2278

Closed ParamThakkar123 closed 2 months ago

ParamThakkar123 commented 2 months ago

Checklist

[X] Appropriate tests were added
[X] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[X] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here. solves a part of #2177

ParamThakkar123 commented 2 months ago

@ChrisRackauckas how can I include rodas5p and rosenbrock23 in ordinarydiffeqdefault? I have shifted them to Ordinarydiffeqrosenbrock

ChrisRackauckas commented 2 months ago

how can I include rodas5p and rosenbrock23 in ordinarydiffeqdefault? I have shifted them to Ordinarydiffeqrosenbrock

OrdinaryDiffEqDefault will need to depend on those two. Keep those two separate, they will be separated in order to improve their load times as they are workhorse methods. For now simply don't move them.

ParamThakkar123 commented 2 months ago

@ChrisRackauckas Should I start a new PR and close this one ?? I think there are a few more things to fix here