Closed ParamThakkar123 closed 2 months ago
Where are the tests for these ones?
Where are the tests for these ones?
I didn't see a separate file of tests for these ones but the tests are there in ode_convergence_tests.jl. The convergence test function for PDIRK44 is present inside Implicit Solver Convergence Tests and tests for KuttaPRK2p5 are present in Explicit Solver Convergence Tests
@ChrisRackauckas any changes to be made in the tests for these solvers ??
@oscardssmith https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/10157523456/job/28087785439?pr=2303#step:6:658 if we don't find a fix soon we'll need to revert the StaticArray change
investigating now.
From initial inspection, this doesn't seem related to my changes since it is happening in addsteps!
which is pretty far away in the code from anything with the jacobians...
It's the ArrayInterface.jl changes.
the ArrayInterface change shouldn't have changed anything here... RecursiveArrayTools depends on StaticArrays unconditionally, and StaticArrays has been loaded, so the extension should still be running...
Ah, the problem is that ArrayInterface.ismutable
is a generated function that illegally depends on world age I think.
>121 @generated function ArrayInterface.ismutable(::Type{<:ArrayPartition{T, S}}) where {T, S
122 }
123 res = all(ArrayInterface.ismutable, S.parameters)
124 return :($res)
125 end
problem found. Partial revert incoming.
Checklist
Additional context
Add any other context about the problem here. solves a part of #2177