Rosenbrock 3rd order perform_step! refactor

SciML / OrdinaryDiffEq.jl

High performance ordinary differential equation (ODE) and differential-algebraic equation (DAE) solvers, including neural ordinary differential equations (neural ODEs) and scientific machine learning (SciML)

https://diffeq.sciml.ai/latest/

Other

536 stars 205 forks source link

Rosenbrock 3rd order perform_step! refactor #2463

Closed ParamThakkar123 closed 1 week ago

ParamThakkar123 commented 3 weeks ago

Checklist

[X] Appropriate tests were added
[X] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[X] Any new documentation only uses public API

Additional context

Add any other context about the problem here. solves a part of #233

ParamThakkar123 commented 3 weeks ago

@oscardssmith can you please review my latest commit ?? It gives me an error saying b is not defined. But I have defined it. Where did I make a mistake here ??

ParamThakkar123 commented 3 weeks ago

@oscardssmith can you please review ? Your reviews can help me move forward with this PR. So I can fix the errors and we can get this merged.

ParamThakkar123 commented 3 weeks ago

@oscardssmith can you please review ? Your reviews can help me move forward with this PR. So I can fix the errors and we can get this merged.

@ChrisRackauckas Can you please review this PR. ??

ParamThakkar123 commented 2 weeks ago

@oscardssmith how the Rosenbrock32 and Rosenbrock23 be combined ?? Most of the test here failed because they are defined but maybe we need to combine them with the RosenbrockCache

ParamThakkar123 commented 2 weeks ago

Rosenbrock32 and Rosenbrock23 have some extra fields in their caches compared to the RosenbrockCache

oscardssmith commented 2 weeks ago

Rosenbrock23 and 32 will need some extra work. Also you will need to make sure you're on a version of master new enough to include https://github.com/SciML/OrdinaryDiffEq.jl/pull/2307 since otherwise it will be totally broken.

ParamThakkar123 commented 2 weeks ago

Rosenbrock23 and 32 will need some extra work. Also you will need to make sure you're on a version of master new enough to include #2307 since otherwise it will be totally broken.

Okay. I need to pull #2307 from the upstream master in my branch

ParamThakkar123 commented 2 weeks ago

@oscardssmith how do I fix this failure ??