search

SciML / PDEBase.jl

Common types and interface for discretizers of ModelingToolkit PDESystems.
MIT License
12 stars 5 forks source link

refactor: parameters are vector of nums/array symbolics and not pairs #30

Closed sathvikbhagavan closed 3 months ago

sathvikbhagavan commented 3 months ago

Parameters are vectors of nums which doesn't carry default values.

ChrisRackauckas commented 3 months ago

They aren't always vectors of nums, are array symbolics handled?

sathvikbhagavan commented 3 months ago

They aren't always vectors of nums, are array symbolics handled?

I think so. https://github.com/SciML/MethodOfLines.jl/pull/404/files#diff-18ef4adc518d89885f85569c138569ad8da7f3a918f5c3a6dc582d9b538a9b33R394 was working with this branch of PDEBase locally. Primary intention is to make it a vector of parameters (both nums and array symbolics) instead of vector of pairs as those values should be given in defaults.