VarLad commented 2 years ago

This PR aims for multifunction encoding as well as introduces the DQCType. The work in this PR is incomplete as compatibility with types from SciMLBase is blocked by Zygote not being able to handle array mutations. Investigation regarding writing an rrule for using Enzyme for the ODE is ongoing, and should be the subject of next PR.

VarLad commented 2 years ago

@ChrisRackauckas Tests passed. If there aren't any problems other than the ones already mentioned, this PR is ready for merge!

codecov[bot] commented 2 years ago

Codecov Report

Merging #10 (64c34be) into main (36c3c2e) will decrease coverage by 3.36%. The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   84.61%   81.25%   -3.37%     
==========================================
  Files           4        4              
  Lines          39       48       +9     
==========================================
+ Hits           33       39       +6     
- Misses          6        9       +3

Impacted Files	Coverage Δ
src/new_circuit.jl	`60.00% <60.00%> (-15.00%)`	:arrow_down:
src/phi.jl	`50.00% <66.66%> (ø)`
src/QuantumNLDiffEq.jl	`95.45% <94.73%> (-4.55%)`	:arrow_down:
src/calculate_diff_evalue.jl	`83.33% <100.00%> (ø)`

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

SciML / QuantumNLDiffEq.jl

Overhaul 1 - Initial Multifunction support, some compatibility with SciML #10

Codecov Report