Closed elisno closed 2 years ago
@VarLad Can you share any references for the circuit that you are trying to optimize here?
@elisno The library is currently broken and will be fixed after an update from Yao :)
You're right. I managed to reproduce the expected plot from the MWE after checking out the master-branch of Yao.jl.
(QuantumNLDiffEq) pkg> st
Project QuantumNLDiffEq v0.0.1
Status `/workspaces/QuantumNLDiffEq.jl/Project.toml`
[587475ba] Flux v0.12.9
[91a5bcdd] Plots v1.27.3
[5872b779] Yao v0.7.1 `https://github.com/QuantumBFS/Yao.jl.git#master`
[418bc28f] YaoBlocks v0.12.1 `https://github.com/QuantumBFS/Yao.jl.git:lib/YaoBlocks#master`
[e88e6eb3] Zygote v0.6.37
Adding a test for this should resolve the issue. I'll keep it open for now.
@elisno The instructions were there in README.md already though :stuck_out_tongue:
Fair enough 😄, but the installation instructions omitted the fact that Yao.jl#master
was required.
The broken plot was based on YaoBlocks#master
, but Yao v0.7.1
.
Everything works after adding
pkg> add Yao#master
Added this suggestion to the PR ( https://github.com/SciML/QuantumNLDiffEq.jl/pull/1/files#r835944190)
@elisno Sorry, I'm not sure if Yao#master is needed :sweat_smile: The plot in README.md was generated using the stable version of Yao and master of YaoBlocks
@VarLad I think you can link #1 to this issue in the PR description before merging.
Fixes #3
@elisno I think this issue is resolved since Yao released a new version
@elisno I think this issue is resolved since Yao released a new version
Yes you're right. I closed the associated PR once you updated the tests. I forgot this issue in the cleanup.
I cannot reproduce this plot from the current example.I can reproduce the plot from the MWE after updating Yao.jl (see https://github.com/SciML/QuantumNLDiffEq.jl/issues/3#issuecomment-1079982349)It would be nice to make a test case that reproduces the plot, or rather the resulting expectation values.
MWE
Expected plot
Actual plot
_Originally posted by @elisno in https://github.com/SciML/QuantumNLDiffEq.jl/pull/1#discussion_r835925088_