search

SciML / ReactionNetworkImporters.jl

Julia Catalyst.jl importers for various reaction network file formats like BioNetGen and stoichiometry matrices
https://docs.sciml.ai/ReactionNetworkImporters/stable/
MIT License
26 stars 8 forks source link

more CI #113

Closed ArnoStrouwen closed 6 months ago

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.72%. Comparing base (7de77b3) to head (efaf03a). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #113 +/- ## ======================================= Coverage 82.72% 82.72% ======================================= Files 4 4 Lines 359 359 ======================================= Hits 297 297 Misses 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArnoStrouwen commented 7 months ago

SciML is moving to throwing errors on hitting deprecation in CI.

I have no idea where the deprecation warning for Catalyst.@register is coming from. The Catalyst version the CI is using does not seem to still use Catalyst.@register? @TorkelE do you have any idea?

ChrisRackauckas commented 7 months ago

It should be @symbolic_register

ArnoStrouwen commented 7 months ago

In Catalyst, everything seems to be the other way around: @register_symbolic.

isaacsas commented 7 months ago

I can’t find anywhere that @register is being used in Catalyst, here, or MTK. Maybe this is some aqua-related issue? I was finding it was giving what seemed like spurious ambiguities at times. Maybe it would be easier to first get these CI additions working with MTK and then Catalyst before here so we can know there aren't issues with lower-level dependencies?

ChrisRackauckas commented 7 months ago

A search isn't finding any https://github.com/search?q=org%3ASciML+register&type=code&p=1. Odd.

ArnoStrouwen commented 6 months ago

This should be good to go now.