search

SciML / RuntimeGeneratedFunctions.jl

Functions generated at runtime without world-age issues or overhead
https://docs.sciml.ai/RuntimeGeneratedFunctions/stable/
MIT License
100 stars 14 forks source link

Make body more generic #60

Closed YingboMa closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (9b02f89) into master (557a861) will decrease coverage by 0.97%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   95.91%   94.94%   -0.97%     
==========================================
  Files           1        1              
  Lines          98       99       +1     
==========================================
  Hits           94       94              
- Misses          4        5       +1
Impacted Files Coverage Δ
src/RuntimeGeneratedFunctions.jl 94.94% <75.00%> (-0.97%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

c42f commented 1 year ago

Interesting. Why did we need this?

ChrisRackauckas commented 1 year ago

It allows for a version that strips the Expr so it could be fully stack allocated.

c42f commented 1 year ago

Right. We could almost make that the default (remove the body field entirely). But only if we were willing to give up on GC of the RGF body expressions in the expression cache.