SciML / SBMLToolkit.jl

SBML differential equation and chemical reaction model (Gillespie simulations) for Julia's SciML ModelingToolkit
https://docs.sciml.ai/SBMLToolkit/stable/
MIT License
40 stars 9 forks source link

basic nameswapping utility for SimBiology #105

Open anandijain opened 1 year ago

anandijain commented 1 year ago

@paulflang what do you think of having this in SBMLTk? i'm happy to just make my own package and have it in there, since this is a bit irrelevant for the package. i just need it open source somewhere

codecov[bot] commented 1 year ago

Codecov Report

Merging #105 (0db6bf3) into main (9499c47) will decrease coverage by 95.82%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #105       +/-   ##
==========================================
- Coverage   95.81%   0.00%   -95.82%     
==========================================
  Files           5       6        +1     
  Lines         287     343       +56     
==========================================
- Hits          275       0      -275     
- Misses         12     343      +331     
Impacted Files Coverage Δ
src/nameswap.jl 0.00% <0.00%> (ø)
src/reactions.jl 0.00% <0.00%> (-99.06%) :arrow_down:
src/events.jl 0.00% <0.00%> (-96.16%) :arrow_down:
src/rules.jl 0.00% <0.00%> (-95.13%) :arrow_down:
src/utils.jl 0.00% <0.00%> (-94.45%) :arrow_down:
src/systems.jl 0.00% <0.00%> (-92.31%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

paulflang commented 1 year ago

Having it is great, but probably better in SBML.jl or as standalone open-source package. In any case, an imported model should be checked for the hash with regex and throw a warning with a quick instruction how the annoying hash can be fixed.