SciML / SBMLToolkit.jl

SBML differential equation and chemical reaction model (Gillespie simulations) for Julia's SciML ModelingToolkit
https://docs.sciml.ai/SBMLToolkit/stable/
MIT License
41 stars 10 forks source link

Pl/catalystupdate #113

Closed paulflang closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #113 (e73bd76) into main (d5d8073) will decrease coverage by 5.77%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   94.23%   88.47%   -5.77%     
==========================================
  Files           6        6              
  Lines         295      295              
==========================================
- Hits          278      261      -17     
- Misses         17       34      +17     
Impacted Files Coverage Δ
src/reactions.jl 94.39% <100.00%> (-4.67%) :arrow_down:
src/systems.jl 83.11% <100.00%> (-9.20%) :arrow_down:
src/utils.jl 88.88% <100.00%> (-5.56%) :arrow_down:
src/events.jl 88.46% <0.00%> (-7.70%) :arrow_down:
src/rules.jl 92.68% <0.00%> (-2.44%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

paulflang commented 1 year ago

@SebastianM-C : here the pr works, but the push does not. does that mean that main will work after merging. cause let's to that then.

paulflang commented 1 year ago

No, wait. somehow this PR also triggered the CI in #112 . Probably because they are indeed the same. Anyway. is this good to merge?