search

SciML / SBMLToolkit.jl

SBML differential equation and chemical reaction model (Gillespie simulations) for Julia's SciML ModelingToolkit
https://docs.sciml.ai/SBMLToolkit/stable/
MIT License
40 stars 9 forks source link

fallback to zero reverse rate #76

Closed paulflang closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (907b278) into main (5ef2abf) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   98.67%   98.69%   +0.02%     
==========================================
  Files           1        1              
  Lines         226      230       +4     
==========================================
+ Hits          223      227       +4     
  Misses          3        3
Impacted Files Coverage Δ
src/reactionsystem.jl 98.69% <100.00%> (+0.02%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

paulflang commented 2 years ago

This PR enables reading of models that contain bidirectional kinetic laws that cannot be separated in forward and reverse. Instead of throwing an error when bidirectional kinetic laws cannot be separated in forward and reverse law, a forward reaction is created with the full kinetic law (which may evaluate to less than zero at some point during the simulation) and a reverse reaction is created with zero as kinetic law. only_use_rate=true is set for both reactions.

anandijain commented 2 years ago

lgtm