SciML / SBMLToolkit.jl

SBML differential equation and chemical reaction model (Gillespie simulations) for Julia's SciML ModelingToolkit
https://docs.sciml.ai/SBMLToolkit/stable/
MIT License
40 stars 9 forks source link

support kwargs[:defaults] in the ReactionSystem constructor #98

Closed paulflang closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #98 (a3a147c) into main (549e601) will decrease coverage by 0.66%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   96.81%   96.15%   -0.67%     
==========================================
  Files           5        5              
  Lines         283      286       +3     
==========================================
+ Hits          274      275       +1     
- Misses          9       11       +2     
Impacted Files Coverage Δ
src/systems.jl 92.30% <33.33%> (-2.36%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

anandijain commented 1 year ago

I think we still want to support forwarding kwargs to the constructor right?

paulflang commented 1 year ago

good shout. can you merge and register once tests pass?

paulflang commented 1 year ago

@anandijain : looking ready to merge and register now (axel and i need this fix)?

anandijain commented 1 year ago

go for it