SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
140 stars 100 forks source link

improve `Vararg` checking #457

Open oscardssmith opened 1 year ago

oscardssmith commented 1 year ago

This code really shouldn't be messing around with function signatures, but if it is, it should do so better. This allows recognizing things like g(x::Vararg{Vector{T}, N}) where {N, T}.

codecov[bot] commented 1 year ago

Codecov Report

Merging #457 (d9d1585) into master (68f2017) will decrease coverage by 2.55%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   49.07%   46.52%   -2.55%     
==========================================
  Files          46       46              
  Lines        3519     3527       +8     
==========================================
- Hits         1727     1641      -86     
- Misses       1792     1886      +94     
Impacted Files Coverage Δ
src/utils.jl 66.45% <90.00%> (+4.36%) :arrow_up:

... and 27 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 1 year ago

This needs a test.

ChrisRackauckas commented 1 year ago

Test failure is real.

ChrisRackauckas commented 1 year ago

bump