search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
129 stars 95 forks source link

make indexing EnsembleSolution work #464

Closed oscardssmith closed 1 year ago

oscardssmith commented 1 year ago

The last test is still failing, but this is almost good to go.

There are also a few typo fixes from https://github.com/SciML/SciMLBase.jl/pull/463 that would have been caught by tests but the tests didn't finish before merging.

codecov[bot] commented 1 year ago

Codecov Report

Merging #464 (0c3f019) into master (32cae24) will decrease coverage by 0.82%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   52.12%   51.30%   -0.82%     
==========================================
  Files          47       47              
  Lines        3555     3559       +4     
==========================================
- Hits         1853     1826      -27     
- Misses       1702     1733      +31
Impacted Files Coverage Δ
src/ensemble/ensemble_solutions.jl 32.38% <75.00%> (-12.52%) :arrow_down:
src/ensemble/basic_ensemble_solve.jl 74.52% <100.00%> (+6.60%) :arrow_up:
src/ensemble/ensemble_problems.jl 72.72% <100.00%> (+18.18%) :arrow_up:

... and 19 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

oscardssmith commented 1 year ago

I think this is now ready to merge.