SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
129 stars 95 forks source link

overload 2 arg show for probs and sols #465

Open oscardssmith opened 1 year ago

oscardssmith commented 1 year ago

@ChrisRackauckas thinks this might break things, but I want to appeal to CI. This makes it so SCIMLProblems and soltuions print nicely when they are within other structs.

codecov[bot] commented 1 year ago

Codecov Report

Merging #465 (d3dbde4) into master (f2eab6b) will increase coverage by 7.97%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   43.47%   51.45%   +7.97%     
==========================================
  Files          47       47              
  Lines        3558     3564       +6     
==========================================
+ Hits         1547     1834     +287     
+ Misses       2011     1730     -281     
Impacted Files Coverage Δ
src/problems/problem_utils.jl 23.33% <0.00%> (+12.09%) :arrow_up:
src/solutions/solution_interface.jl 54.45% <0.00%> (+25.37%) :arrow_up:

... and 28 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 1 year ago

So this should close?

oscardssmith commented 1 year ago

No. I'm planning on updating this today so that the 2 argument version prints a compact view (but moved onto 1 line).