SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
129 stars 95 forks source link

`DataFrame` export #469

Open oscardssmith opened 1 year ago

oscardssmith commented 1 year ago

This allows getting a DataFrame from an ODE or Ensemble solution.

codecov[bot] commented 1 year ago

Codecov Report

Merging #469 (40abe8d) into master (f2eab6b) will increase coverage by 5.59%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   43.47%   49.07%   +5.59%     
==========================================
  Files          47       48       +1     
  Lines        3558     3582      +24     
==========================================
+ Hits         1547     1758     +211     
+ Misses       2011     1824     -187     
Impacted Files Coverage Δ
ext/SciMLBaseDataFramesExt.jl 0.00% <0.00%> (ø)
src/ensemble/ensemble_solutions.jl 40.56% <0.00%> (-0.95%) :arrow_down:
src/solutions/solution_interface.jl 46.17% <0.00%> (+17.09%) :arrow_up:

... and 25 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 1 year ago

ensemble indexing tests fail with this?

devmotion commented 1 year ago

I always assumed the solutions support the Tables interface? Doesn't DataFrame(x) support anything that supports the Tables interface?