Closed gaurav-arya closed 1 year ago
Merging #473 (8834b3a) into master (091c91a) will increase coverage by
0.15%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 57.62% 57.78% +0.15%
==========================================
Files 47 47
Lines 3578 3577 -1
==========================================
+ Hits 2062 2067 +5
+ Misses 1516 1510 -6
Impacted Files | Coverage Δ | |
---|---|---|
src/scimlfunctions.jl | 59.57% <100.00%> (+0.92%) |
:arrow_up: |
... and 5 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I think to handle other downstream tests, SDE, DDE, and SDDE would be required since they use the same nonlinear solver code paths.
Not necessarily because of the check useed in https://github.com/SciML/OrdinaryDiffEq.jl/pull/1996 here: https://github.com/SciML/OrdinaryDiffEq.jl/blob/e476b24726ffa639d61696178eeab0f5e8622171/src/derivative_utils.jl#L851
I don't think it would be too much work to add it and test if you'd rather do it all at once. But AFAIU it can also be done after
Adds a
W_prototype
to the ODEFunction, allowing for a user specified W-operator (in particular, as a SciMLOperator).