SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
137 stars 99 forks source link

Return successful `retcode` on `MaxIters` for `OptimizationSolution` #475

Closed Vaibhavdixit02 closed 1 year ago

Vaibhavdixit02 commented 1 year ago

For global, stochastic gradient etc maxiters is used as the stopping criteria

ChrisRackauckas commented 1 year ago

This is not the solution. The solution is to just correctly throw Success if that's what the return code is supposed to be. MaxIters is defined as a non-converged early max iterations return, not a successful return.