SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
129 stars 95 forks source link

fix segfault when interpolating on failed solution #476

Closed oscardssmith closed 1 year ago

oscardssmith commented 1 year ago

Fixes https://github.com/SciML/SciMLBase.jl/issues/458 Previously the check for whether the interpolation was being asked to extrapolate outside the time range assumed that at least two steps were taken. (otherwise t[end]-t[1] == 0). This would then cause a segfault when you actually try to do the interpolation.

codecov[bot] commented 1 year ago

Codecov Report

Merging #476 (308e0a9) into master (f549934) will decrease coverage by 0.35%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
- Coverage   56.62%   56.28%   -0.35%     
==========================================
  Files          47       47              
  Lines        3583     3587       +4     
==========================================
- Hits         2029     2019      -10     
- Misses       1554     1568      +14     
Files Changed Coverage Δ
src/interpolation.jl 33.20% <50.00%> (+0.25%) :arrow_up:

... and 13 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more