SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
127 stars 92 forks source link

Fix ODEFunction constructor #483

Closed YingboMa closed 12 months ago

codecov[bot] commented 12 months ago

Codecov Report

Merging #483 (8d7de64) into master (a6b09ce) will decrease coverage by 1.52%. The diff coverage is 17.64%.

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   57.28%   55.76%   -1.52%     
==========================================
  Files          50       50              
  Lines        3657     3658       +1     
==========================================
- Hits         2095     2040      -55     
- Misses       1562     1618      +56     
Files Changed Coverage Δ
src/ensemble/basic_ensemble_solve.jl 80.18% <ø> (ø)
src/ensemble/ensemble_solutions.jl 44.95% <0.00%> (ø)
src/scimlfunctions.jl 57.89% <ø> (-1.90%) :arrow_down:
src/ensemble/ensemble_problems.jl 40.90% <10.00%> (-1.95%) :arrow_down:
ext/ZygoteExt.jl 50.00% <40.00%> (ø)

... and 9 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 12 months ago

How did this come up? AutoSpecialize is almost always going to be preferred to NoSpecialize

YingboMa commented 12 months ago

JuliaSimCompiler switches to NoSpecialize when the IR is sufficiently big.

ChrisRackauckas commented 12 months ago

Does that actually make a difference?

YingboMa commented 12 months ago

It helped compare to FullSpecialize, but I didn't compare it to AutoSpecialize.