search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
127 stars 92 forks source link

Fix adjoints for ODESolution indexing #494

Closed frankschae closed 11 months ago

frankschae commented 11 months ago

Can/Should we add an upstream test to the Core1 group of SciMLSensitivity?

ChrisRackauckas commented 11 months ago

Yes, please add upstream tests to scimlsensitivity. I would add all core tests.

codecov[bot] commented 11 months ago

Codecov Report

Merging #494 (f132824) into master (73eb334) will decrease coverage by 14.41%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #494       +/-   ##
===========================================
- Coverage   57.00%   42.60%   -14.41%     
===========================================
  Files          50       50               
  Lines        3703     3697        -6     
===========================================
- Hits         2111     1575      -536     
- Misses       1592     2122      +530
Files Changed Coverage Δ
src/SciMLBase.jl 71.42% <ø> (ø)
src/solutions/zygote.jl 30.76% <100.00%> (-15.39%) :arrow_down:

... and 35 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more