search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
127 stars 92 forks source link

Make ODEProblem into a mutable struct #496

Closed wsmoses closed 11 months ago

wsmoses commented 11 months ago

Required for use in a reverse-mode EnzymeRule. Otherwise there is a mixed activity for having both floats and vector{floats}, not behind a pointer.

ChrisRackauckas commented 11 months ago

I'm not sure we can take that since the semantics of a mutable struct vs struct will make it harder on parallelism. We should chat about this.

codecov[bot] commented 11 months ago

Codecov Report

Merging #496 (705a524) into master (03cdaed) will decrease coverage by 3.73%. Report is 80 commits behind head on master. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   57.27%   53.55%   -3.73%     
==========================================
  Files          50       50              
  Lines        3703     3701       -2     
==========================================
- Hits         2121     1982     -139     
- Misses       1582     1719     +137
Files Changed Coverage Δ
src/problems/ode_problems.jl 43.58% <ø> (-12.83%) :arrow_down:

... and 21 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more