search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
127 stars 92 forks source link

Make ODEProblem into a mutable struct, v2 #501

Closed ChrisRackauckas closed 11 months ago

ChrisRackauckas commented 11 months ago

Adds a big warning not to use it. This is only for EnzymeRules to work given current limitations!!!

codecov[bot] commented 11 months ago

Codecov Report

Merging #501 (97517dd) into master (f14a1ff) will decrease coverage by 13.96%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #501       +/-   ##
===========================================
- Coverage   53.83%   39.88%   -13.96%     
===========================================
  Files          50       50               
  Lines        3769     3761        -8     
===========================================
- Hits         2029     1500      -529     
- Misses       1740     2261      +521
Files Changed Coverage Δ
src/problems/ode_problems.jl 27.71% <0.00%> (-15.88%) :arrow_down:

... and 33 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Datseris commented 11 months ago

I am hoping that this didn't have any impact to performance downstream when stepping ODE Integrators, right?

ChrisRackauckas commented 11 months ago

It shouldn't. I didn't notice an immediate impact. Do mention if you see one.