SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
127 stars 92 forks source link

Add PyCall extension #502

Closed LilithHafner closed 10 months ago

codecov[bot] commented 11 months ago

Codecov Report

Merging #502 (931449c) into master (75b1925) will increase coverage by 2.92%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   53.37%   56.29%   +2.92%     
==========================================
  Files          50       51       +1     
  Lines        3798     3803       +5     
==========================================
+ Hits         2027     2141     +114     
+ Misses       1771     1662     -109     
Files Coverage Δ
ext/PyCallExt.jl 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LilithHafner commented 11 months ago

I'm not sure how to make sense of the test failures. The last merged PR had 55/72 successes, this has 54/71. Tests pass locally for me.

ChrisRackauckas commented 11 months ago

It's not you it's me 😅

We just did the v2 release yesterday, and this is package used by hundreds of other packages so the breaking update will take awhile to propagate through all of the downstream packages and pass.

LilithHafner commented 10 months ago

What's the status here? Is there anything I should do to help?

ChrisRackauckas commented 10 months ago

The tests are failing because it doesn't find pyjulia to be installed. Try moving the conda pip stuff to before the pycall is loaded? Somehow it needs to install that package on the Julia side to test it

LilithHafner commented 10 months ago

Ah, lovely! And I can use this CI failure as a guide, thanks!

LilithHafner commented 10 months ago

Here's a quote from the last CI failure: "Defaulting to user installation because normal site-packages is not writeable"

LilithHafner commented 10 months ago

Python tests pass! 🎉

ChrisRackauckas commented 10 months ago

Awesome, thanks for pushing through it!