search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
127 stars 92 forks source link

Fix tests failings for TwoPointBVPFunction #517

Closed ErikQQY closed 10 months ago

ErikQQY commented 10 months ago

This should fix the tests failings in DiffEqBase.jl https://github.com/SciML/DiffEqBase.jl/pull/940

@ChrisRackauckas @avik-pal

codecov[bot] commented 10 months ago

Codecov Report

Merging #517 (25b27be) into master (75b1925) will increase coverage by 2.93%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   53.37%   56.30%   +2.93%     
==========================================
  Files          50       50              
  Lines        3798     3806       +8     
==========================================
+ Hits         2027     2143     +116     
+ Misses       1771     1663     -108
Files Coverage Δ
src/remake.jl 58.01% <83.33%> (+4.41%) :arrow_up:
src/problems/bvp_problems.jl 44.82% <55.55%> (+6.89%) :arrow_up:

... and 11 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 10 months ago

@avik-pal is this still needed after https://github.com/SciML/SciMLBase.jl/pull/518 ?

ChrisRackauckas commented 10 months ago

This PR is now out of date because of the changes in https://github.com/SciML/SciMLBase.jl/pull/518, so closing, but a similar PR to the new function form is required.