Closed lxvm closed 11 months ago
Merging #535 (10307a5) into master (6b0a385) will decrease coverage by
1.06%
. The diff coverage is35.29%
.
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 56.04% 54.98% -1.06%
==========================================
Files 54 54
Lines 3981 3988 +7
==========================================
- Hits 2231 2193 -38
- Misses 1750 1795 +45
Files | Coverage Δ | |
---|---|---|
src/scimlfunctions.jl | 61.02% <ø> (-1.33%) |
:arrow_down: |
src/problems/basic_problems.jl | 66.66% <35.29%> (-12.09%) |
:arrow_down: |
... and 11 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This pr is needed by Integrals.jl so that the new interface introduced in SciMLBasev2 can correctly reproduce the old behavior. Mainly, the documentation now says that the integrand prototypes are arrays of the same kind as what the integrand will consume, and integral algorithms are responsible for providing those same arrays.
The only additional thing I added were
getproperty
methods for the bounds of the integration domain. Although these will no longer be used by the updated Integrals.jl, it could help avoid bugs for users migrating to the new version.